New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update release notes with all deprecations for 1.12 release #19735
Conversation
[skip actions] [skip cirrus]
[skip actions] [skip cirrus]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note about the sparse solvers is not correct/complete.
doc/source/release/1.12.0-notes.rst
Outdated
- The deprecation of the ``tol`` argument of ``scipy.sparse.linalg.{gcrotmk,lgmres,minres,tfqmr}`` | ||
is now consistent with the other iterative solvers and will be removed in SciPy 1.14 | ||
in favour of ``rtol``. Further, the default value of ``atol`` for these functions is due | ||
to change to ``0.0`` in SciPy 1.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo a slight refomulation this LGTM, so I'll put this in. Thanks! :)
Fix-up where GH UI did not allow suggestion
Doc build is broken by #19793. Since we're going to have to fix that separately anyway, I'm merging here. |
…py#19735) Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Reference issue
What does this implement/fix?
Adds a couple missing entries to the deprecation section of the release notes
Additional information
cc @h-vetinari @tylerjereddy