Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: SuperLU upstream fix for compile warnings #19768

Merged
merged 1 commit into from Dec 28, 2023

Conversation

alugowski
Copy link
Contributor

Reference issue

Closes #19767

What does this implement/fix?

Fixes build warnings by bringing in the fix from upstream: xiaoyeli/superlu#128

@github-actions github-actions bot added scipy.sparse.linalg scipy.sparse C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks labels Dec 27, 2023
@tylerjereddy tylerjereddy added this to the 1.13.0 milestone Dec 27, 2023
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the patch is clearly small and seems safe enough, I would point out that we usually separate the application of individual SuperLU patches to a file scipy/sparse/linalg/_dsolve/SuperLU/scipychanges.patch.

Presumably this serves a few purposes, but the obvious is just organizational. While it is probably far more important to use that file for patches that have not yet been upstreamed, it may still make sense to use it here so that we're clear that we haven't updated to latest version again, just applied an individual patch.

There's some more recent discussion here: #19284. I'm not necessarily trying to block this PR though, just want whoever decides to merge to have this in mind.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's already fixed upstream, let's not bother with the patch file. We'll definitely pull in the fix next time we update SuperLU, so it'd only be extra work to remove the patch from the patch file at that point.

Thanks @alugowski for doing this, and thanks @tylerjereddy for the review.

@rgommers rgommers merged commit bee9b9a into scipy:main Dec 28, 2023
27 of 28 checks passed
@alugowski alugowski deleted the superluwarn branch January 5, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks scipy.sparse.linalg scipy.sparse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warnings from SuperLU fixed upstream
4 participants