Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC/BLD: macOS Homebrew OpenBlas detection advice #19787

Merged
merged 1 commit into from Jan 3, 2024
Merged

DOC/BLD: macOS Homebrew OpenBlas detection advice #19787

merged 1 commit into from Jan 3, 2024
+5 −0

Conversation

lucascolley
Copy link
Member

Reference issue

#19784 (comment)

What does this implement/fix?

Advises on a potential fix for OpenBlas detection on macOS with Homebrew.

@github-actions github-actions bot added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org Build issues Issues with building from source, including different choices of architecture, compilers and OS labels Jan 1, 2024
@lucascolley lucascolley added the DX Everything related to making the experience of working on SciPy more pleasant label Jan 1, 2024
@lucascolley lucascolley added this to the 1.13.0 milestone Jan 3, 2024
rgommers
rgommers approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lucascolley

@rgommers rgommers merged commit bb72c15 into scipy:main Jan 3, 2024
25 of 26 checks passed
@rgommers
Copy link
Member

rgommers commented Jan 3, 2024

For next time: consider adding [skip actions] in the commit message of a docs-only PR. The only relevant CI jobs are on CircleCI.

@lucascolley
Copy link
Member Author

For next time: consider adding [skip actions] in the commit message of a docs-only PR.

I added [docs only] which only ran the CircleCI jobs and the linter - the only GHAs that ran were the jobs to check the commit message :)

@lucascolley lucascolley deleted the brew-openblas branch January 3, 2024 09:04
@rgommers
Copy link
Member

rgommers commented Jan 3, 2024

Ah wait, that changed - there are more green checkmarks, but they're very short jobs indeed. Sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org DX Everything related to making the experience of working on SciPy more pleasant
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucascolley @rgommers