Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG:sparse:Add early exit to gmres when x0 already solves problem #19952

Merged
merged 1 commit into from Jan 23, 2024
Merged

BUG:sparse:Add early exit to gmres when x0 already solves problem #19952

merged 1 commit into from Jan 23, 2024

Conversation

ilayn
Copy link
Member

@ilayn ilayn commented Jan 23, 2024

Reference issue

Closes #19948

@ilayn ilayn added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.sparse.linalg backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Jan 23, 2024
@ilayn ilayn added this to the 1.12.1 milestone Jan 23, 2024
j-bowhay
j-bowhay approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-bowhay j-bowhay merged commit 11ce9d7 into scipy:main Jan 23, 2024
28 of 30 checks passed
@ilayn ilayn deleted the gmres_x0 branch January 23, 2024 20:22
@lucascolley lucascolley modified the milestones: 1.12.1, 1.13.0 Mar 12, 2024
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

@perimosocordiae perimosocordiae Awaiting requested review from perimosocordiae perimosocordiae is a code owner

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.sparse.linalg scipy.sparse
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

BUG: scipy.sparse.linalg.gmres fails when provided x0 solves the system
4 participants
@ilayn @j-bowhay @tylerjereddy @lucascolley