Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Add proper error message for ShortTimeFFT for onesided FFTs and complex signals #20010

Merged
merged 1 commit into from Feb 2, 2024
Merged

BUG: Add proper error message for ShortTimeFFT for onesided FFTs and complex signals #20010

merged 1 commit into from Feb 2, 2024

Conversation

DietBru
Copy link
Contributor

@DietBru DietBru commented Feb 2, 2024

  • Raise ValueError in ShortTimeFFT.sft_detrend if parameter x is complex and ShortTimeFFT.onesided_fft is true.
  • Added unit test.
  • Updated documentation.

Closes issue #20009.

@DietBru
BUG: Add proper error message for ShortTimeFFT for onesided FFTs an…
9716022 
…d complex signals.

* Raise ValueError in `ShortTimeFFT.sft_detrend` if parameter `x` is complex and `ShortTimeFFT.onesided_fft` is true.
* Added unit test.
* Updated documentation.

Closes Issue scipy#20009
@github-actions github-actions bot added scipy.signal defect A clear bug or issue that prevents SciPy from being installed or used as expected labels Feb 2, 2024
j-bowhay
j-bowhay approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DietBru LGTM and test failure appears to unrelated

@j-bowhay j-bowhay added this to the 1.13.0 milestone Feb 2, 2024
@j-bowhay j-bowhay merged commit fe967c7 into scipy:main Feb 2, 2024
27 of 29 checks passed
@j-bowhay j-bowhay linked an issue Feb 2, 2024 that may be closed by this pull request
BUG: ShortTimeFFT fails with complex input #20009
Closed
@bencwallace bencwallace mentioned this pull request Feb 3, 2024
Merged
@DietBru DietBru mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@ilayn ilayn Awaiting requested review from ilayn ilayn is a code owner

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.signal
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

BUG: ShortTimeFFT fails with complex input
2 participants
@DietBru @j-bowhay