Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: interpolate: _interpnd_info does not need installing #20153

Merged
merged 1 commit into from Feb 27, 2024

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Feb 27, 2024

There is no need to install _interpnd_info.py: this is a helper file, it does not provide any user-facing functionality, it is not accessible from the scipy.interpolate namespace --- it can live in the repo but there is hardly any reason for it to end up on a user system.

@ev-br ev-br added scipy.interpolate maintenance Items related to regular maintenance tasks labels Feb 27, 2024
@ev-br ev-br requested a review from rgommers February 27, 2024 19:08
@github-actions github-actions bot added Meson Items related to the introduction of Meson as the new build system for SciPy Build issues Issues with building from source, including different choices of architecture, compilers and OS labels Feb 27, 2024
@ev-br
Copy link
Member Author

ev-br commented Feb 27, 2024

I wanted to write "it's similar to scipy/special/_precompute which does not get installed" --- but _precompute does get installed, cf https://github.com/scipy/scipy/blob/main/scipy/special/meson.build#L408 --- ! I actually wonder if it needs to @steppi?

@lucascolley lucascolley added this to the 1.13.0 milestone Feb 27, 2024
@steppi
Copy link
Contributor

steppi commented Feb 27, 2024

I wanted to write "it's similar to scipy/interpolate/_precompute which does not get installed" --- but _precompute does get installed, cf https://github.com/scipy/scipy/blob/main/scipy/special/meson.build#L408 --- ! I actually wonder if it needs to @steppi?

Some of the stuff is imported in test code,

https://github.com/scipy/scipy/blob/main/scipy/special/tests/test_precompute_expn_asy.py
https://github.com/scipy/scipy/blob/main/scipy/special/tests/test_precompute_gammainc.py
https://github.com/scipy/scipy/blob/main/scipy/special/tests/test_precompute_utils.py

but it looks like this is for tests that the _precompute scripts are working correctly, not for direct tests of anything user facing.

Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe enough, there's a sympy import in there too, so clearly not something to be exported to users, and CI is happy.

Thanks Evgeni

@tylerjereddy tylerjereddy merged commit b5868a9 into scipy:main Feb 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy scipy.interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants