TST:special:Add partial tests for nrdtrimn and nrdtrisd #20173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures don't seem relevant. |
steppi
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Thanks @ilayn. The tests look good. I've been planning to work on improving the test infrastructure stuff for special functions and will find some time to fit it in over the next couple months. Did you mean to include the noncentral t updates here? If so, can you split the PR into two commits, one for the tests, and one for the noncentral t updates? After that, I'll do a regular merge.
|
Ah yes looks like I used the wrong branch for fixes. Will fix |
Revert "TST:special:Add partial tests for nrdtri*" This reverts commit 722d9f0. TST:special:Add partial tests for nrdtri*
|
Let me get this in so we don't have merge conflicts for other additions, thanks @steppi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Related : #19953
What does this implement/fix?
Adds partial tests for special functions.
It seems to me that the generic testing infra we have right now is not suitable for customization of parameter domains and it is a bit convoluted. It takes quite some investigation to see what is going on and debugging what failed. Hence I think there is domain expertise needed for the rewrite of the testing suite.
But at least it is better than nothing for now.