-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: 1.13.0rc1 prep [wheel build] #20279
MAINT: 1.13.0rc1 prep [wheel build] #20279
Conversation
* A few more version-related changes, and some chance of screw up here given special circumstances of a new major NumPy release, but have to continue at it. * mixed in with our own version-related changes here are adjustments to avoid some of the "nightly" shims for NumPy pre-release in wheel build infrastructure itself, which perhaps also makes sense to happen on `main` now that the NumPy 2 beta is on PyPI (depends what you want to test though...); I was somewhat concerned this may otherwise lead to us getting nightly NumPy builds off of `main` instead of more official builds from PyPI (in theory, we're supposed to support `2.1.0` as well, but that seems like an extra degree of confusion and not our desired build target for immediate RC1 wheels...) * start probing the wheel builds to see what goes wrong as we look to RC1 and building alongside NumPy 2 [wheel build]
@h-vetinari how do things stand on your end re: major concerns? |
nothing apparently! |
I haven't tested the 1.13 branch yet, but from my POV I don't have concerns with tagging the release candidate. I'll build that in conda-forge and report back on any issues. I've marked one fix as a backport candidate that would be nice to have for 1.13.0 GA, but not necessary for rc1. |
These changes look ok to me. |
Feels like I'm a bit too lucky here, but ok CI is green and folks are happy so in it goes. |
I had a scroll through the logs, it all looks ready for RC1. This was the one warning that should out; not an immediate problem, but may break the Windows builds once MinGW-w64 reaches 14.0 I suspect:
I'll have a long at that later, looks like a minor issue in NumPy. |
A few more version-related changes, and some chance of screw up here given special circumstances of a
new major NumPy release, but have to continue at it.
mixed in with our own version-related changes here are adjustments to avoid some of the "nightly" shims for NumPy pre-release in wheel build infrastructure itself, which perhaps also makes sense to happen on
main
now that the NumPy 2 beta is on PyPI (depends what you want to test though...);I was somewhat concerned this may otherwise lead to us getting nightly NumPy builds off of
main
instead of more official builds from PyPI (in theory, we're supposed to support2.1.0
as well, but that seems like an extra degree of confusion and not our desired build target for immediate RC1 wheels...)start probing the wheel builds to see what goes wrong as we look to RC1 and building alongside NumPy 2
[wheel build]