New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: spatial: use cython_lapack in spatial/_qhull.pyx #20337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff seems sensible and passed full suite locally with my setup as well.
I did notice I could make this cleanup on this branch now, with full suite still passing locally, any reason not do do that:
--- a/scipy/spatial/meson.build
+++ b/scipy/spatial/meson.build
@@ -40,7 +40,7 @@ py3.extension_module('_qhull',
'qhull_src/src'
],
link_args: version_link_args,
- dependencies: [lapack, np_dep],
+ dependencies: [np_dep],
install: true,
subdir: 'scipy/spatial'
)
Indeed. Added your patch to the PR. |
Thanks Evgeni |
Do you think this would help with #20271, even if it's just about easier debugging? If so, should we still backport this to 1.13? |
That's clutching at straws basically: if we're in luck, the issue was in the manual lapack wrappers, as unlikely as it is. The alternative is rather bleak, it'd likely mean the issue is in vendored qhull code. A stack trace would be really helpful. |
Yeah, I know. I'll try to look into it when I'm back at my laptop in about a week. |
Use
linalg.cython_lapack
in_qhull.pyx
instead of manual LAPACK wrappers (the qhull usage likely predates cython_lapack).Just a small drive-by cleanup while looking at #20271