Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: refactor array API testing #20368

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

MAINT: refactor array API testing #20368

wants to merge 1 commit into from

Conversation

lucascolley
Copy link
Member

@lucascolley lucascolley commented Apr 1, 2024 •
edited

Reference issue

n/a

What does this implement/fix?

Various improvements to code quality and minor refactors.

  • The shorthand for pytest.mark.skip_xp_backends is now only defined once and imported.
  • Organised imports
  • Updated scipy._lib._array_api.__all__

This has introduced a few extra shims in the _lib and conftest code, but I think it is worth it for simplifying the imports.

Additional information

I'll add a blame-ignore before merge.

@github-actions github-actions bot added scipy.stats scipy.special scipy.optimize scipy.cluster scipy._lib Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.fft DX Everything related to making the experience of working on SciPy more pleasant array types Items related to array API support and input array validation (see gh-18286) maintenance Items related to regular maintenance tasks labels Apr 1, 2024
@lucascolley lucascolley removed scipy.stats scipy.special scipy.optimize scipy.cluster Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.fft labels Apr 1, 2024
@lucascolley lucascolley marked this pull request as draft April 1, 2024 13:06
@lucascolley lucascolley force-pushed the xp-refactor branch 5 times, most recently from 0fe792b to 8d7e623 Compare April 1, 2024 16:00
@lucascolley lucascolley force-pushed the xp-refactor branch 2 times, most recently from 1e5b4ff to 5bcb177 Compare April 1, 2024 17:02
@lucascolley
MAINT: refactor array API testing
e0a0c88 
[skip circle] [skip cirrus]
@lucascolley
Copy link
Member Author

It looks like the main thing I was trying to do here isn't going to work, I'd somehow have to force the custom pytest marks to be generated before any submodule is imported. There is some value in the rest of what's here, but I might just close this.

@lucascolley lucascolley added the needs-work Items that are pending response from the author label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@person142 person142 Awaiting requested review from person142 person142 will be requested when the pull request is marked ready for review person142 is a code owner

@steppi steppi Awaiting requested review from steppi steppi will be requested when the pull request is marked ready for review steppi is a code owner

@andyfaff andyfaff Awaiting requested review from andyfaff andyfaff will be requested when the pull request is marked ready for review andyfaff is a code owner

@peterbell10 peterbell10 Awaiting requested review from peterbell10 peterbell10 will be requested when the pull request is marked ready for review peterbell10 is a code owner

Assignees
No one assigned
Labels
array types Items related to array API support and input array validation (see gh-18286) DX Everything related to making the experience of working on SciPy more pleasant maintenance Items related to regular maintenance tasks needs-work Items that are pending response from the author scipy._lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lucascolley