MAINT: update pybind11 and numpy build-time requirements for 1.13.0 #20374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
approved these changes
Apr 1, 2024
tylerjereddy
approved these changes
Apr 1, 2024
That's up to @tylerjereddy. But if we do it, we should do the final release very quickly after; an extra week of waiting is too long and will hamper the numpy 2.0 rollout across the ecosystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the last build dependency related TODO before the final 1.13.0 release.
pybind112.12.0 is the minimum version needed for numpy 2.0 compatibility; older versions will raise an error since numpy 2.0.0rc1.