DOC: add missing deprecations from 1.13.0 release notes

[j-bowhay]

Reference issue

remake of #20431

What does this implement/fix?

Several deprecations were missing from the 1.13 release notes, this PR adds them

Additional information

cc @tylerjereddy @h-vetinari @lucascolley sorry not sure how I missed this, have been very busy with uni this year

[lucascolley]

LGTM, will let @h-vetinari check nothing has been missed.

[lucascolley]

Actually, I think we need to add that these changes occurred in 1.13.0 but were missed from the notes at the time.

[h-vetinari]

Thank you!

[h-vetinari]

Actually, I think we need to add that these changes occurred in 1.13.0 but were missed from the notes at the time.

I think we should just merge this for main & the release branch (not sure if the versioned website is built from the tag or the branch - I hope it's the latter?), and if possible, ask @tylerjereddy to update the notes that are attached to the github release for 1.13.0. That way all major places (to my knowledge) where people can look at the release notes would be up to date, even without a 1.13.1 release.

[lucascolley]

Okay, SGTM. I suppose I was thinking of a case where someone checked the release notes on release, thought "great, no expired deprecations!", then later tries to upgrade, runs into problems and doesn't understand why the expired deprecations have now appeared.

That is admittedly very niche, so let's get this in. Thanks all!

[j-bowhay]

Looks like the doc failure here was real

[lucascolley]

Ah sorry, missed that. I can fix it.

[tylerjereddy]

I've updated the GitHub release page version of the 1.13.0 release notes accordingly.

[j-bowhay]

I've updated the GitHub release page version of the 1.13.0 release notes accordingly.

Many thanks!

[tylerjereddy]

I think there's a small blemish here too, the extra preceding backtick shows up in the rendered version of the relnotes:

https://scipy.github.io/devdocs/release/1.13.0-notes.html#deprecated-features

Pretty minor though

[h-vetinari]

Thanks a lot @tylerjereddy!

I propose we should still backport this to the release branch before the regular batch of PRs, so that the 1.13 docs online get updated as well.

[tylerjereddy]

I suppose you mean to manually rebuild and reupload the docs for the 1.13.0 release with the expired deprecations added?

That I certainly don't normally do, but I'll add a calendar reminder to consider doing it at least. I don't know if that would really have much to do with backport order. If I just checkout the tag, apply the release notes patches only (without committing them), and re-upload it wouldn't likely matter much if things get backported as they usually do I suspect.

I also need to carefully clean out the backport-labelled PRs, that's a mess now, but I'm a bit swamped on grant writing.

[h-vetinari]

I suppose you mean to manually rebuild and reupload the docs for the 1.13.0 release with the expired deprecations added?

No, it was not my intention to ask for manual work (except one of us doing the backport PR), but it's possible I misunderstood how our docs get published. My hope would have been that any commit on release/1.13.x pushes new docs to https://docs.scipy.org/doc/scipy-1.13.0/. If that's not the case, then we can wait until 1.13.1.

[tylerjereddy]

An nope, although @tupui probably would agree with your wishes of it being more streamlined like the devdocs stuff.

There's this thing where we do make dist and then make upload, and then it goes to some server owned by Enthought team, so different than the devdocs route.

Maybe we'll streamline that at some point, it can get hard to reason about what is going on with those two routes to doc upload.

[ev-br]

I also need to carefully clean out the backport-labelled PRs, that's a mess now, but I'm a bit swamped

Is there something we can help with?