MAINT: stats._contains_nan: fix bug when -inf and inf are in sample #20467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
maintenance
github-actions
bot
added
scipy._lib
Documentation
mdhaber
removed
Documentation
j-bowhay
approved these changes
May 14, 2024
mdhaber
commented
May 14, 2024
| contains_nan = xp.isnan(xp.sum(a)) | ||
| else: | ||
| contains_nan = xp.any(xp.isnan(a)) | ||
| if a.size == 0: |
There was a problem hiding this comment.
Oops, I should have used _array_api.size here. Will do in gh-20667.
tylerjereddy
added
the
backport-candidate
|
Title is prefixed with |
mdhaber
added
backport-candidate
|
Might be tricky to backport because this is mixed with adding array API support to the function, which is a new feature. Up to you, though. |
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-20386
What does this implement/fix?
gh-20386 reported that
stats.kstestreturned NaNs when both positive and negative infinities were present in the sample. This fixes the (very old) underlying bug.Additional information
This includes all the gh-20292 commits, so that should merge first.
I could add a test for
_contains_nandirectly if desired. (Currently, this just adds a test for the reported issue inkstest.)