Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Move Python-including files to start of source. #20537

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented Apr 20, 2024

This should allow Cygwin to build in the next release.

Reference issue

Backport of #20505
Closes #20491

What does this implement/fix?

This moves a few python-including headers earlier in their respective files.

Additional information

DWesl#7 tests whether this compiles on Cygwin.

This should allow Cygwin to build in the next release.
@github-actions github-actions bot added scipy.special scipy.io C/C++ Items related to the internal C/C++ code base Build issues Issues with building from source, including different choices of architecture, compilers and OS labels Apr 20, 2024
@tylerjereddy tylerjereddy added this to the 1.13.1 milestone Apr 20, 2024
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, and thanks for checking the Cygwin build, that saves me some headaches.

I assume a few test failures on Cygwin is acceptable for us at the moment. If not, feel free to ping me on additional things I should backport.

@tylerjereddy tylerjereddy merged commit 1cea374 into scipy:maintenance/1.13.x Apr 20, 2024
28 of 29 checks passed
@DWesl
Copy link
Contributor Author

DWesl commented Apr 20, 2024

There's many fewer failures than I remember, only two in Cephes and two other special functions failures. I suppose I could track down what dl_iterate_phdr is and why threadpoolctl thinks Cygwin would have it, but I suspect that would not qualify as a backport, as such.

Given the ctypes interface, I suspect adding or sys.platform == "cygwin" to this line might help:
https://github.com/joblib/threadpoolctl/blob/master/threadpoolctl.py#L980

@DWesl DWesl deleted the cygwin-compile-fixes branch April 20, 2024 22:02
@tylerjereddy tylerjereddy mentioned this pull request May 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS C/C++ Items related to the internal C/C++ code base scipy.io scipy.special
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants