Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: optimize.isotonic_regression: remove unnecessary copies #20582

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lorentzenchr
Copy link
Contributor

Reference issue

None

What does this implement/fix?

Small improvement for unweighted isotonic regression.

Additional information

Saves unnecessary array copies.

@github-actions github-actions bot added scipy.optimize enhancement A new feature or improvement labels Apr 25, 2024
@lucascolley lucascolley changed the title ENH unweighted isotonic_regression ENH: optimize.isotonic_regression: remove unnecessary copies Apr 26, 2024
@lucascolley lucascolley changed the title ENH: optimize.isotonic_regression: remove unnecessary copies MAINT: optimize.isotonic_regression: remove unnecessary copies Apr 26, 2024
@lucascolley lucascolley added enhancement A new feature or improvement maintenance Items related to regular maintenance tasks and removed enhancement A new feature or improvement labels Apr 26, 2024
@lucascolley
Copy link
Member

I've reclassified this as maintenance, but feel free to provide a benchmark if you think this is worth a release note

@lorentzenchr
Copy link
Contributor Author

lorentzenchr commented Apr 26, 2024

Maintenance is fine. It’s a minor improvement.

@lucascolley lucascolley added this to the 1.14.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants