Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: lint: temporarily disable UP031 #20601

Merged
merged 1 commit into from
Apr 28, 2024
Merged

MAINT: lint: temporarily disable UP031 #20601

merged 1 commit into from
Apr 28, 2024
+2 −1

Conversation

lucascolley
Copy link
Member

New failures are showing up. At a guess, the detection was fixed / improved in the latest ruff version. These should be fixed, but I am a bit time-poor, and this will help keep everyone sane while we get a few PRs in.

I'll open a follow-up issue with the failures that I see.

@github-actions github-actions bot added the maintenance Items related to regular maintenance tasks label Apr 28, 2024
@lucascolley lucascolley mentioned this pull request Apr 28, 2024
Merged
3 tasks
@lucascolley lucascolley removed the request for review from larsoner April 28, 2024 22:40
@lucascolley lucascolley added this to the 1.14.0 milestone Apr 28, 2024
@lucascolley
Copy link
Member Author

Here are the errors while I have them in my terminal, using ruff v0.4.2

benchmarks/benchmarks/optimize.py:91:15: UP031 Use format specifiers instead of percent format
doc/source/conf.py:75:13: UP031 Use format specifiers instead of percent format
scipy/_build_utils/_wrappers_common.py:106:26: UP031 Use format specifiers instead of percent format
scipy/_lib/_util.py:271:22: UP031 Use format specifiers instead of percent format
scipy/_lib/_util.py:721:26: UP031 Use format specifiers instead of percent format
scipy/_lib/_util.py:722:36: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2226:16: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2229:29: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2231:30: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2234:30: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2241:34: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2244:34: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2247:34: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2250:30: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2253:30: UP031 Use format specifiers instead of percent format
scipy/cluster/hierarchy.py:2577:26: UP031 Use format specifiers instead of percent format
scipy/cluster/vq.py:472:26: UP031 Use format specifiers instead of percent format
scipy/cluster/vq.py:477:30: UP031 Use format specifiers instead of percent format
scipy/cluster/vq.py:775:26: UP031 Use format specifiers instead of percent format
scipy/constants/_constants.py:282:35: UP031 Use format specifiers instead of percent format
scipy/constants/_constants.py:295:35: UP031 Use format specifiers instead of percent format
scipy/fft/_pocketfft/tests/test_basic.py:873:19: UP032 [*] Use f-string instead of `format` call
scipy/fft/_pocketfft/tests/test_basic.py:876:45: UP031 Use format specifiers instead of percent format
scipy/fftpack/tests/test_basic.py:762:19: UP032 [*] Use f-string instead of `format` call
scipy/fftpack/tests/test_basic.py:765:45: UP031 Use format specifiers instead of percent format
scipy/integrate/_quadrature.py:1139:19: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:805:39: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:819:29: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:932:26: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:952:30: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:1367:30: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:1442:26: UP031 Use format specifiers instead of percent format
scipy/interpolate/_bsplines.py:1637:26: UP031 Use format specifiers instead of percent format
scipy/interpolate/_fitpack_py.py:376:30: UP031 Use format specifiers instead of percent format
scipy/interpolate/_fitpack_py.py:441:21: UP031 Use format specifiers instead of percent format
scipy/interpolate/_interpolate.py:519:39: UP031 Use format specifiers instead of percent format
scipy/interpolate/_interpolate.py:918:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/_interpolate.py:1467:29: UP031 Use format specifiers instead of percent format
scipy/interpolate/_interpolate.py:1776:29: UP031 Use format specifiers instead of percent format
scipy/interpolate/_interpolate.py:1972:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/tests/test_bsplines.py:839:26: UP031 Use format specifiers instead of percent format
scipy/io/_fast_matrix_market/__init__.py:533:26: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio4.py:121:27: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio4.py:151:29: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio4.py:180:30: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio4.py:302:29: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio5.py:314:31: UP031 Use format specifiers instead of percent format
scipy/io/matlab/_mio5.py:336:23: UP031 Use format specifiers instead of percent format
scipy/io/matlab/tests/test_mio.py:302:35: UP031 Use format specifiers instead of percent format
scipy/io/matlab/tests/test_mio.py:1276:38: UP031 Use format specifiers instead of percent format
scipy/io/wavfile.py:775:30: UP031 Use format specifiers instead of percent format
scipy/linalg/_basic.py:1276:26: UP031 Use format specifiers instead of percent format
scipy/linalg/_basic.py:1279:50: UP031 Use format specifiers instead of percent format
scipy/linalg/_solvers.py:321:26: UP031 Use format specifiers instead of percent format
scipy/linalg/_special_matrices.py:422:26: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1182:33: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1186:49: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1206:37: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1211:45: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1215:45: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1237:37: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1242:45: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1248:41: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1265:37: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1270:45: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1299:51: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1305:51: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1335:51: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1341:51: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1369:51: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1399:47: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1427:29: UP031 Use format specifiers instead of percent format
scipy/linalg/tests/test_basic.py:1431:37: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:292:34: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:420:38: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:539:34: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:617:23: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:852:28: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:858:21: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:863:21: UP031 Use format specifiers instead of percent format
scipy/odr/_odrpack.py:869:17: UP031 Use format specifiers instead of percent format
scipy/optimize/_linesearch.py:429:23: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:39:24: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:270:18: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:459:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:461:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:467:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:472:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:475:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_minpack_py.py:478:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_nonlin.py:424:34: UP031 Use format specifiers instead of percent format
scipy/optimize/_nonlin.py:899:30: UP031 Use format specifiers instead of percent format
scipy/optimize/_nonlin.py:1479:34: UP031 Use format specifiers instead of percent format
scipy/optimize/_nonlin.py:1554:26: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:178:23: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:925:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:1469:15: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:1813:15: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:2016:19: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:2657:26: UP031 Use format specifiers instead of percent format
scipy/optimize/_optimize.py:3567:15: UP031 Use format specifiers instead of percent format
scipy/optimize/_root.py:220:14: UP031 Use format specifiers instead of percent format
scipy/optimize/_root.py:260:26: UP031 Use format specifiers instead of percent format
scipy/optimize/tests/test_minpack.py:324:35: UP031 Use format specifiers instead of percent format
scipy/optimize/tests/test_minpack.py:333:35: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2382:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2384:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2579:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2584:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2587:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2616:35: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:2654:35: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:3815:26: UP031 Use format specifiers instead of percent format
scipy/signal/_filter_design.py:4004:26: UP031 Use format specifiers instead of percent format
scipy/signal/_fir_filter_design.py:260:26: UP031 Use format specifiers instead of percent format
scipy/signal/_fir_filter_design.py:1015:26: UP031 Use format specifiers instead of percent format
scipy/signal/_fir_filter_design.py:1302:26: UP031 Use format specifiers instead of percent format
scipy/signal/_lti_conversion.py:531:26: UP031 Use format specifiers instead of percent format
scipy/signal/_signaltools.py:2132:39: UP031 Use format specifiers instead of percent format
scipy/signal/_signaltools.py:4206:26: UP031 Use format specifiers instead of percent format
scipy/signal/_signaltools.py:4325:35: UP031 Use format specifiers instead of percent format
scipy/signal/_spectral_py.py:1764:26: UP031 Use format specifiers instead of percent format
scipy/signal/_spectral_py.py:1774:26: UP032 [*] Use f-string instead of `format` call
scipy/signal/_spectral_py.py:1901:26: UP031 Use format specifiers instead of percent format
scipy/signal/tests/test_filter_design.py:3638:59: UP031 Use format specifiers instead of percent format
scipy/signal/tests/test_filter_design.py:3642:53: UP031 Use format specifiers instead of percent format
scipy/signal/tests/test_filter_design.py:3646:53: UP031 Use format specifiers instead of percent format
scipy/signal/tests/test_signaltools.py:2393:59: UP031 Use format specifiers instead of percent format
scipy/sparse/_base.py:251:29: UP031 Use format specifiers instead of percent format
scipy/sparse/_base.py:271:35: UP031 Use format specifiers instead of percent format
scipy/sparse/_base.py:287:35: UP031 Use format specifiers instead of percent format
scipy/sparse/_bsr.py:49:42: UP031 Use format specifiers instead of percent format
scipy/sparse/_bsr.py:97:42: UP032 [*] Use f-string instead of `format` call
scipy/sparse/_bsr.py:106:34: UP031 Use format specifiers instead of percent format
scipy/sparse/_csr.py:93:34: UP031 Use format specifiers instead of percent format
scipy/sparse/_dia.py:71:34: UP031 Use format specifiers instead of percent format
scipy/sparse/_generate_sparsetools.py:206:26: UP031 Use format specifiers instead of percent format
scipy/sparse/linalg/_isolve/lgmres.py:172:32: UP031 Use format specifiers instead of percent format
scipy/sparse/tests/test_base.py:4298:29: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2190:30: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2424:34: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2432:38: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2438:38: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2448:38: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2519:34: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2529:34: UP031 Use format specifiers instead of percent format
scipy/spatial/distance.py:2990:30: UP031 Use format specifiers instead of percent format
scipy/spatial/tests/test_distance.py:212:26: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:307:23: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:330:17: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:508:30: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:635:22: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:636:21: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:645:21: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:647:23: UP031 Use format specifiers instead of percent format
scipy/special/_generate_pyx.py:781:26: UP031 Use format specifiers instead of percent format
scipy/stats/_continuous_distns.py:54:25: UP031 Use format specifiers instead of percent format
scipy/stats/_continuous_distns.py:3343:28: UP031 Use format specifiers instead of percent format
scipy/stats/_distn_infrastructure.py:430:30: UP031 Use format specifiers instead of percent format
scipy/stats/_distn_infrastructure.py:790:26: UP031 Use format specifiers instead of percent format
scipy/stats/_distn_infrastructure.py:2676:29: UP031 Use format specifiers instead of percent format
scipy/stats/_distn_infrastructure.py:3889:26: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:133:26: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:457:30: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:834:38: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:1326:26: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:4314:26: UP031 Use format specifiers instead of percent format
scipy/stats/_morestats.py:4317:26: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:480:24: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:1499:26: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:2009:30: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:2044:34: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:2050:34: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:2071:30: UP031 Use format specifiers instead of percent format
scipy/stats/_multivariate.py:4774:24: UP031 Use format specifiers instead of percent format
scipy/stats/_stats_py.py:2511:23: UP031 Use format specifiers instead of percent format
scipy/stats/_stats_py.py:8505:26: UP031 Use format specifiers instead of percent format
scipy/stats/_stats_py.py:9158:26: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_distributions.py:5855:25: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:107:19: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:167:15: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:168:16: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:169:16: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:170:30: UP031 Use format specifiers instead of percent format
scipy/stats/tests/test_fit.py:177:29: UP031 Use format specifiers instead of percent format
tools/check_installation.py:61:29: UP031 Use format specifiers instead of percent format
tools/check_installation.py:71:29: UP031 Use format specifiers instead of percent format
tools/generate_f2pymod.py:132:18: UP031 Use format specifiers instead of percent format
tools/generate_f2pymod.py:150:20: UP031 Use format specifiers instead of percent format
tools/generate_f2pymod.py:158:16: UP031 Use format specifiers instead of percent format
tools/generate_f2pymod.py:170:34: UP031 Use format specifiers instead of percent format
tools/openblas_support.py:180:20: UP031 Use format specifiers instead of percent format
tools/openblas_support.py:191:20: UP031 Use format specifiers instead of percent format
Found 193 errors.

@lucascolley
Copy link
Member Author

Seems to be due to astral-sh/ruff#11019. FYI @mdhaber

tylerjereddy
tylerjereddy approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, yeah I just saw these locally a few hours ago when working on the signal array API stuff.

@tylerjereddy tylerjereddy merged commit 2f0cd1b into scipy:main Apr 28, 2024
28 checks passed
@lucascolley lucascolley deleted the disable-up031 branch April 28, 2024 23:07
@lucascolley lucascolley mentioned this pull request Apr 28, 2024
Open
rgommers added a commit to rgommers/scipy that referenced this pull request May 2, 2024
@rgommers
DEV: lint: disable UP031
1f17de5 
Showed up as a linting error in an unrelated PR for me:
```
scipy/interpolate/_interpolate.py:918:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/_interpolate.py:1972:30: UP032 [*] Use f-string instead of `format` call
```
This should not happen; the old code is fine, so this check needs to be
silenced or fixed separately. Similar to scipygh-20601.

[skip ci]
@rgommers rgommers mentioned this pull request May 2, 2024
Merged
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 15, 2024
@tylerjereddy tylerjereddy modified the milestones: 1.14.0, 1.13.1 May 15, 2024
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request May 15, 2024
@rgommers @tylerjereddy
DEV: lint: disable UP031
5582720 
Showed up as a linting error in an unrelated PR for me:
```
scipy/interpolate/_interpolate.py:918:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/_interpolate.py:1972:30: UP032 [*] Use f-string instead of `format` call
```
This should not happen; the old code is fine, so this check needs to be
silenced or fixed separately. Similar to scipygh-20601.

[skip ci]
@tylerjereddy tylerjereddy mentioned this pull request May 15, 2024
Merged
10 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucascolley @tylerjereddy