Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Micro-optimizations for spatial.transform.Rotation methods #20656

Merged
merged 1 commit into from
May 14, 2024
Merged

ENH: Micro-optimizations for spatial.transform.Rotation methods #20656

merged 1 commit into from
May 14, 2024

Conversation

scottshambaugh
Copy link
Contributor

@scottshambaugh scottshambaugh commented May 6, 2024 •
edited

Reference issue

N/A

What does this implement/fix?

Makes two small optimizations for Rotations, should hopefully speed up some of the basic operations:

  • Skip normalization when inverting rotations.
  • Skip normalization when raising to the first power and returning a copy of self

Additional information

N/A

@github-actions github-actions bot added scipy.spatial Cython Issues with the internal Cython code base enhancement A new feature or improvement labels May 6, 2024
@lucascolley lucascolley added this to the 1.14.0 milestone May 6, 2024
@scottshambaugh
Copy link
Contributor Author

Pinging @nmayorov for review

@nmayorov
Copy link
Contributor

Looks reasonable to me, merging.

@nmayorov nmayorov merged commit 471c3d1 into scipy:main May 14, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmayorov nmayorov nmayorov left review comments

@tylerjereddy tylerjereddy Awaiting requested review from tylerjereddy tylerjereddy is a code owner

@peterbell10 peterbell10 Awaiting requested review from peterbell10 peterbell10 is a code owner

Assignees
No one assigned
Labels
Cython Issues with the internal Cython code base enhancement A new feature or improvement scipy.spatial
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scottshambaugh @nmayorov @lucascolley