MAINT: stats.kruskal: fix no-arg behavior w/ SCIPY_ARRAY_API=1 #20663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI
tylerjereddy
approved these changes
May 8, 2024
|
Thanks @tylerjereddy. I agree that it didn't need another stats opinion since it really doesn't involve the test itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-20661
What does this implement/fix?
Fixes the failing test
test_axis_nan_policy_decorated_positional_argswhenSCIPY_ARRAY_API=1. Changes to low-level stats private methods have created the same sort failure twice (first due to adding array API support to_get_nan, now due to adding support to_broadcast_arrays), so I've added a similar test intest_statsthat will run on the array API job regularly.