CI: pin Python for MacOS conda #20727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We're seeing CI failures related to an undesirable bump to Python `3.12` in this job, when the intention was clearly to respect the Python version specific in the GHA matrix. I didn't check too closely why exactly it suddenly started happening, but some packages weren't ready for `3.12` yet on this job (`scikit-umfpack` in particular) and I don't see too much harm in adding an extra pin to respect the intention for the Python version. [skip cirrus] [skip circle]
tylerjereddy
added
maintenance
tylerjereddy
added
the
backport-candidate
tylerjereddy
changed the title
|
Seems to have dealt with the issue. I do wonder if there's a bit of a misunderstanding about the Python pin guarantees we get with the |
10 tasks
lucascolley
approved these changes
May 16, 2024
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20714
We're seeing CI failures related to an undesirable bump to Python
3.12in this job, when the intention was clearly to respect the Python version specified in the GHA matrix. I didn't check too closely why exactly it suddenly started happening, but some packages weren't ready for3.12yet on this job (scikit-umfpackin particular) and I don't see too much harm in adding an extra pin to respect the intention for the Python version.I tried checking on my fork but it gets skipped unless I mod the GHA branch checks I think. If this turns into a bunch of shenanigans I'll make another branch and iterate on my fork.
[skip cirrus] [skip circle]