-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: stats.normaltest/jarque_bera: add array-API support #20736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 tasks
mdhaber
commented
May 18, 2024
mdhaber
changed the title
ENH: stats.normaltest: add array-API support
ENH: stats.normaltest/jarque_bera_test: add array-API support
May 18, 2024
mdhaber
changed the title
ENH: stats.normaltest/jarque_bera_test: add array-API support
ENH: stats.normaltest/jarque_bera add array-API support
May 18, 2024
lucascolley
changed the title
ENH: stats.normaltest/jarque_bera add array-API support
ENH: stats.normaltest/jarque_bera: add array-API support
May 18, 2024
mdhaber
commented
May 18, 2024
@@ -6308,31 +6310,22 @@ def test_input_validation(self): | |||
|
|||
|
|||
class TestJarqueBera: | |||
def test_jarque_bera_stats(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with a stronger test.
lucascolley
added
the
array types
Items related to array API support and input array validation (see gh-18286)
label
May 18, 2024
j-bowhay
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
array types
Items related to array API support and input array validation (see gh-18286)
enhancement
A new feature or improvement
scipy.stats
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-20544
What does this implement/fix?
Adds array API support to
stats.normaltest
andstats.jarque_bera
.Additional information
Draft to let gh-20085 merge first.
Will also address #20085 (comment) if we figure out what was going on there.
Next PR will rewrite all these tests.