-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes pointed out by Eclipse PyDev static code analysis #2942
Conversation
@@ -238,19 +238,19 @@ def __init__(self, data, leafsize=10): | |||
class node(object): | |||
if sys.version_info[0] >= 3: | |||
def __lt__(self, other): | |||
id(self) < id(other) | |||
return id(self) < id(other) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a unit test for this change would be in order.
From a quick check it also looks like the |
@larsmans @rgommers These issues were just pointed out by a static code analysis ... I've never used these parts of |
This was fixed in 6c618a3.
I've sent to a PR to @cdeil's repo with a test for the KDTree stuff. |
Test for KDTree.node fix
Thanks @larsmans ... merged your PR into this one. |
Here's fixes for a few scipy issues pointed out by my editor (Eclipse PyDev).
I'm not familiar with the code and didn't test, so please check the changes carefully.
There's two more that I think might be real issues where I don't know what the correct fix is:
https://coveralls.io/files/59355318#L199
https://coveralls.io/files/59355112#L258
All of these issues are not covered by unit tests.