Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: linalg: don't recommend np.linalg.norm #2987

Merged
merged 1 commit into from
Oct 14, 2013

Conversation

larsmans
Copy link
Contributor

The scipy.linalg.norm docstring is quite confusing because it seems to recommend np.linalg.norm instead, even though that function can be several times slower. It also has an axis keyword that scipy.linalg.norm doesn't have, adding to the confusion.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ef66145 on larsmans:scipy-not-numpy-norm into 57ac922 on scipy:master.

rgommers added a commit that referenced this pull request Oct 14, 2013
DOC: linalg: don't recommend np.linalg.norm
@rgommers rgommers merged commit 7479249 into scipy:master Oct 14, 2013
@rgommers
Copy link
Member

Agreed, this is clearer. Thanks @larsmans

@larsmans larsmans deleted the scipy-not-numpy-norm branch October 14, 2013 20:09
@WarrenWeckesser
Copy link
Member

FYI: In numpy 1.8, numpy.linalg.norm has an axis argument.

@ewmoore
Copy link
Member

ewmoore commented Oct 15, 2013

Warren Weckesser wrote:

FYI: In numpy 1.8, |numpy.linalg.norm| has an |axis| argument.


Reply to this email directly or view it on GitHub
#2987 (comment).

Truthfully, there is no reason that scipy and numpy should be different
here. Can we open an issue (say labeled as a Task) on the numpy tracker
(or here if necessary) to normalize these two? I understand that it may
require wrapping (s,d,sc,dz)nrm2 and adding it to blas_lite.

@larsmans
Copy link
Contributor Author

I have a PR over at NumPy that uses dot in norm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants