Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Binned statistic #3064

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

Dapid commented Nov 14, 2013

Closes issue #3063

@josef-pkt josef-pkt commented on an outdated diff Nov 14, 2013

scipy/stats/tests/test_binned_statistic.py
@@ -217,6 +217,27 @@ def test_dd_bincode(self):
assert_array_almost_equal(bc, bc2)
count1adj = count1[count1.nonzero()]
assert_array_almost_equal(bcount, count1adj)
+
+ def test_range(self):
+ x = np.arange(30)
+ data = np.random.random(30)
@josef-pkt

josef-pkt Nov 14, 2013

Member

We add a seed to random tests, so the results are reproducable.

Member

josef-pkt commented Nov 14, 2013

Looks good to me, I don't see any problems merging (besides missing random seed to follow our "policy")

should be fully backwards compatible

Contributor

Dapid commented Nov 14, 2013

Seed added.

Contributor

Dapid commented Nov 15, 2013

This should fix it for good.

Coverage Status

Coverage remained the same when pulling 606ea9f on Dapid:binned_statistic into dc14aee on scipy:master.

rgommers added a commit that referenced this pull request Nov 17, 2013

Owner

rgommers commented Nov 17, 2013

Merged in 0bfd1ab, thanks @Dapid and @josef-pkt. I squashed the commits and reshuffled the tests a bit to reduce code duplication.

@Dapid for writing the commit message it would be useful to follow the advice in http://docs.scipy.org/doc/numpy-dev/dev/gitwash/development_workflow.html#writing-the-commit-message

@rgommers rgommers closed this Nov 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment