Binned statistic #3064
Closed
Binned statistic #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_range(self): | ||
| x = np.arange(30) | ||
| data = np.random.random(30) |
There was a problem hiding this comment.
We add a seed to random tests, so the results are reproducable.
|
Looks good to me, I don't see any problems merging (besides missing random seed to follow our "policy") should be fully backwards compatible |
|
Seed added. |
|
This should fix it for good. |
rgommers
added a commit
that referenced
this pull request
Nov 17, 2013
|
Merged in 0bfd1ab, thanks @Dapid and @josef-pkt. I squashed the commits and reshuffled the tests a bit to reduce code duplication. @Dapid for writing the commit message it would be useful to follow the advice in http://docs.scipy.org/doc/numpy-dev/dev/gitwash/development_workflow.html#writing-the-commit-message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #3063