Fix Issue #3067 fix cumptrapz that was raising an exception when x !=None and axis not in (0, -1) #3068

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@francisco-dlp

No description provided.

@pv
Member
pv commented Nov 15, 2013

This change breaks something: https://travis-ci.org/scipy/scipy/jobs/14022194#L2588
Also, please add tests relevant for the behavior you want.
You should use python runtests.py -s integrate to run the tests on your own machine to catch test failures like this before actually submitting a pull request.

@francisco-dlp

I assumed that it was a small typo and I made a pull request without even running the tests—sorry for that.

My last commit fixes what the previous one broke and adds tests for the new feauture i.e. the y is nd and x is 1d case.

@coveralls

Coverage Status

Coverage remained the same when pulling 060eda8 on francisco-dlp:fix_cumptrapz into dc14aee on scipy:master.

@rgommers rgommers added a commit that referenced this pull request Dec 16, 2013
@rgommers rgommers Merge branch 'pr-3068' into master.
See #3068
006a95f
@rgommers
Member

Thanks @francisco-dlp, looks good. Merged.

@rgommers rgommers closed this Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment