Arff reader with nominal value of 1 character #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 16, 2013 15:27
The arff io reader fails to load arff files containing a single nominal value of only 1 character. Adds a test demonstrating the failure in this case.
Alteres the regex for parsing nominal values in arff files so that single character nominal values can now be successfully parsed.
rgommers
added a commit
that referenced
this pull request
Nov 17, 2013
Arff reader with nominal value of 1 character
|
Thanks George, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, attributes consisting of a single nominal value whose name is 1 character will cause "loadarff" to fail (admittedly, this is a bit of an edge case).
Adds a test case covering this issue.