Arff reader with nominal value of 1 character #3073

Merged
merged 3 commits into from Nov 17, 2013

Projects

None yet

3 participants

@ghl3

Previously, attributes consisting of a single nominal value whose name is 1 character will cause "loadarff" to fail (admittedly, this is a bit of an edge case).

Adds a test case covering this issue.

ghl3 added some commits Nov 16, 2013
@ghl3 ghl3 Adds failing test for nominal arff reading
The arff io reader fails to load arff files containing
a single nominal value of only 1 character.  Adds a
test demonstrating the failure in this case.
e10cbbc
@ghl3 ghl3 Fixes failing test of arff reader
Alteres the regex for parsing nominal values in
arff files so that single character nominal
values can now be successfully parsed.
f57c39c
@ghl3 ghl3 Fixes arff io test name e6fceed
@coveralls

Coverage Status

Coverage remained the same when pulling e6fceed on ghl3:arff_nominal_fix into 11d8bee on scipy:master.

@rgommers rgommers merged commit 3077e4f into scipy:master Nov 17, 2013

1 check passed

Details default The Travis CI build passed
@rgommers
SciPy member

Thanks George, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment