Bug: should return 0 if no regions found #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check on `n` for all tests of label()
Added special-case logic for the case were no regions were found so that 0 is returned instead of 1 Fixes issue scipy#3082
|
@thouis want to review this one? |
|
Looks good to me. |
rgommers
added a commit
that referenced
this pull request
Nov 24, 2013
Bug: should return 0 if no regions found
|
Thanks, merged. Will backport to 0.13.x as well. |
|
backported in aeac90a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the test coverage to check that the returned number of regions is correct.
Added special case above the merge logic in _ni_label.pyx
It may be better to short-circuit this earlier, but I thought this would be the minimal change.
fixes #3082