File object support for imread and imsave #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. I'll try to have a closer look at this in a few days. It's indeed ugly that we have two |
|
OK I'm not going to get around to reworking the |
| @@ -100,21 +100,21 @@ def bytescale(data, cmin=None, cmax=None, high=255, low=0): | |||
| return cast[uint8](bytedata) + cast[uint8](low) | |||
|
|
|||
|
|
|||
| def imread(name,flatten=0): | |||
| def imread(imfile, flatten=0): | |||
There was a problem hiding this comment.
This is actually a backwards compatibility break, because you can use positional arguments like kwargs (like imread(name='fname.png')). So can you undo this change?
|
Can you add a test for the functionality you add here to |
|
With a test and undoing the rename this should be good to go. |
|
Finally got around to make these changes. |
pv
added a commit
that referenced
this pull request
Feb 24, 2014
ENH: misc: File object support for imread and imsave
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to image reading and writing routines to support file objects properly. Actually scipy.misc.imread didn't have to be changed because PIL already supports file objects, but I changed the docstring to say explicitly that it supports them. I made similar changes to scipy.ndimage.misc.imread, though I'm not quite sure why that can't just import from scipy.misc.