clean up tests for discrete distributions #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are too noisy: only work for decimal=0.
| distname + ' skew_kurt' | ||
| yield check_cdf_ppf, distfn, arg, supp, distname + ' cdf_ppf' | ||
|
|
||
| cond = distname == 'skellam' |
There was a problem hiding this comment.
Don't you want to keep running this test for skellam with the original test accuracy instead of marking it knownfail?
There was a problem hiding this comment.
OK, done. We do this already for ncf anyway.
|
Looks good to me. |
rgommers
added a commit
that referenced
this pull request
Dec 15, 2013
clean up tests for discrete distributions
|
Thanks Evgeni, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten up the test accuracies here and there.
Remove several non-running tests.
Completely remove sample tests for the moments, since
assert_almost_equal(..., ... decimal=0))Overall test coverage does not decrease.