Skip to content

use numpy sinc #3175

Merged
merged 2 commits into from Dec 29, 2013

6 participants

@argriffing

No description provided.

@coveralls

Coverage Status

Coverage remained the same when pulling 7cc24c1 on argriffing:remove-sinc into 371b4ff on scipy:master.

@rgommers
SciPy member

+1, no need to duplicate this function.

I checked the numpy implementation, and that looks fine to me. The 1e-20 used there doesn't affect the precision it seems.

@rgommers
SciPy member

The tests for special.sinc should also be removed in this PR.

EDIT: maybe keep a very basic one to check that the function still exists in the special namespace.

@coveralls

Coverage Status

Coverage remained the same when pulling 284023e on argriffing:remove-sinc into 371b4ff on scipy:master.

@argriffing

@rgommers I removed most of the testing.

@rgommers
SciPy member

Thanks, merging.

@rgommers rgommers merged commit 7eca39e into scipy:master Dec 29, 2013

1 check passed

Details default The Travis CI build passed
@rgommers rgommers referenced this pull request Dec 29, 2013
Closed

sinc #3069

@endolith

Would it make sense to move the tests and implementation into numpy instead of just deleting them? scipy's implementation makes more sense to me than something that depends on float inaccuracy.

@argriffing

@endolith The numpy sinc passed the scipy tests, and numpy has its own more extensive sinc testing. On the other hand I'd like a new C sinc ufunc implementation in either numpy or scipy.

@rgommers
SciPy member

New ufunc would indeed be nice. That should go into numpy and replace its current implementation imho.

@argriffing

New ufunc would indeed be nice. That should go into numpy and replace its current implementation imho.

related: numpy/numpy#7322

@madphysicist

For the immediate future, numpy/numpy#7322 will actually remove the possibility of making np.sinc into a ufunc. However, I also have plans to work around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.