Fix test errors with numpy master #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1089,7 +1089,7 @@ def test_structured_arrays(self): | |||
| bb = np.array(list(zip(b, b)), dt) | |||
| v = stats.itemfreq(aa) | |||
| # Arrays don't compare equal because v[:,0] is object array | |||
| assert_equal(v[2, 0], bb[2]) | |||
| assert_equal(tuple(v[2, 0]), tuple(bb[2])) | |||
There was a problem hiding this comment.
this is a know regression in numpy:
numpy/numpy#3804
There was a problem hiding this comment.
Thanks. It was kinda puzzling. Still doesn't hurt to make this change here.
|
Any objections to merging this one? Should all be trivial fixes. |
pv
added a commit
that referenced
this pull request
Jan 31, 2014
TST: fix test errors with numpy master
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some cleanup in ndimage tests.