Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a bit of maintanence work in stats #3243

Merged
merged 7 commits into from
Jan 31, 2014
Merged

a bit of maintanence work in stats #3243

merged 7 commits into from
Jan 31, 2014

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Jan 26, 2014

closes gh-2741 and gh-2871
also remove a couple of unused and duplicate attributes of distributions.

josef-pkt
josef-pkt reviewed Jan 26, 2014
View reviewed changes
scipy/stats/mstats_basic.py
@@ -2006,7 +2006,7 @@ def f_oneway(*args):
msb = ssbg/float(dfbg)
msw = sswg/float(dfwg)
f = msb/msw
prob = stats.fprob(dfbg,dfwg,f)
prob = special.fdtrc(dfbg, dfwg, f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using stats.f.sf would be more informative

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, have added an explicit comment in the last commit (+ similar in mstats).

@josef-pkt
Copy link
Member

looks good to me

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 63f5807 on ev-br:distr_cleanup into 8ad48cd on scipy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3a92e44 on ev-br:distr_cleanup into 8ad48cd on scipy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0e29858 on ev-br:distr_cleanup into 8ad48cd on scipy:master.

rgommers added a commit that referenced this pull request Jan 31, 2014
@rgommers
Merge pull request #3243 from ev-br/distr_cleanup
64fbe99 
a bit of maintanence work in stats
@rgommers rgommers merged commit 64fbe99 into scipy:master Jan 31, 2014
@rgommers
Copy link
Member

LGTM, thanks @ev-br, @josef-pkt

@ev-br ev-br deleted the distr_cleanup branch January 31, 2014 23:34
@ev-br ev-br mentioned this pull request Feb 14, 2014
Closed
@rgommers
Copy link
Member

Hmm, veccdf, vecfunc and vec_generic_moment should indeed have been deprecated. No idea why I overlooked that when merging this PR. Those methods probably didn't work as expected for some distributions, but that doesn't really matter.

Guess it doesn't help much to put them back in 0.14.1 as deprecated methods, but maybe we should do that anyway.

@ev-br
Copy link
Member Author

ev-br commented May 17, 2014

I still think all these were private implementation details of going from computational _XXX methods to user-callable XXX methods, but obviously I'm on a trigger-happy side when it comes to deprecations.

FWIW, I think adding them back in 0.14.1 does not make much sense. To have an alternative, I'd offer to help fixing the code which this change broke downstream. @yarikoptic care to share a link?

@pv
Copy link
Member

pv commented May 17, 2014

Adding them back might make sense, as 0.14.0 has not been out for a long time yet, and for example Linux distributions always lag behind.

rgommers added a commit to rgommers/scipy that referenced this pull request May 26, 2014
@rgommers
DEP: put back veccdf/vecfunc/vec_generic_momemt in stats.distributions.
556220b 
Removed erroneously in scipygh-3243 for 0.14.0.  These methods were always
private ones but not marked as such, and as the comments on scipygh-3243 show
they were used. Hence now deprecated.
@rgommers rgommers mentioned this pull request May 26, 2014
Merged
@rgommers
Copy link
Member

PR to put them back: gh-3685.

rgommers added a commit that referenced this pull request Jul 5, 2014
@rgommers
DEP: put back veccdf/vecfunc/vec_generic_momemt in stats.distributions.
b5db4cc 
Removed erroneously in gh-3243 for 0.14.0.  These methods were always
private ones but not marked as such, and as the comments on gh-3243 show
they were used. Hence now deprecated.

(cherry picked from commit 556220b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scipy.stats
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

stats: deprecate and remove alias for special functions
6 participants
@ev-br @josef-pkt @coveralls @rgommers @pv @yarikoptic