Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX support axis=-1 and -2 for sparse reduce methods #3253

Merged
merged 3 commits into from
Jan 30, 2014

Conversation

jnothman
Copy link
Contributor

Fixes #3249

@pv
Copy link
Member

pv commented Jan 28, 2014

A better idiom could be to add to the top-level axis-using functions

if axis < 0:
    axis += self.ndim

and then proceed as usual.

@pv
Copy link
Member

pv commented Jan 29, 2014

Please also fix getnnz while you're at it ;)

@jnothman
Copy link
Contributor Author

A better idiom ...

If you rather.

@cowlicks
Copy link
Contributor

I was unaware of the axis=-1 feature when I implemented this! Thanks for the good work @jnothman !

@jnothman
Copy link
Contributor Author

@cowlicks, you can blame @jaimefrio for demanding it...

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5936e4c on jnothman:neg_axis into c683ff9 on scipy:master.

pv added a commit that referenced this pull request Jan 30, 2014
BUG: sparse: support axis=-1 and -2 for sparse reduce methods
@pv pv merged commit 2793794 into scipy:master Jan 30, 2014
@pv
Copy link
Member

pv commented Jan 30, 2014

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.sparse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparse matrix min/max/etc don't support axis=-1
4 participants