Skip to content

Also generate a tar.xz when running paver sdist #3278

Closed
wants to merge 3 commits into from

5 participants

@tomspur
tomspur commented Feb 4, 2014

Would it be possible to also generate a tar.xz, when generating sdists?

This patch generates a tar.xz when running paver sdist as a first step.

@rgommers
SciPy member
rgommers commented Feb 4, 2014

Can you explain why you need this format?

And would it have to be paver sdist itself or would you be equally helped by an extra paver xsdist command for example? With this patch I'd have to delete this format straight after creating it in the release scripts, because I don't need it for uploading to sourceforge/pypi.

@coveralls

Coverage Status

Coverage remained the same when pulling 9006e0a on tomspur:tar.xz into 5309706 on scipy:master.

@tomspur
tomspur commented Feb 4, 2014

With a current checkout, the tar.xz is about 30% smaller than the tar.gz. Offering a tar.xz file for downloading would therefore need less space and bandwidth and especially the former is often an issue, when offering a source distribution (see e.g. here).

That's why I added it topaver sdist on purpose, so it is always generated and it can be directly uploaded...

It would be very nice to have it on sourceforge/pypi (and many other projects also provide tar.xz as download option - and many other don't), but is not absolutely needed :)

@rgommers
SciPy member
rgommers commented Feb 5, 2014

For me it's the latter right now, downloads time out regularly here. So there is a benefit to this, I'm fine with uploading .tar.xz to PyPi and SF. Although .tag.gz should remain the default.

@rgommers
SciPy member
rgommers commented Feb 5, 2014

I'll merge this in a day or two unless anyone sees an issue with providing these downloads.

@tomspur
tomspur commented Feb 5, 2014

Great. Thanks! :)

@rgommers
SciPy member
rgommers commented Feb 8, 2014

Tried this and it fails for me on OS X 10.9:

xz dist/scipy-0.14.0.dev-dc79d97.tar
Build failed running pavement.sdist: Subprocess return code: 127

No time to debug right now.

@tomspur
tomspur commented Feb 9, 2014

It seems you don't have xz installed on your system. Do you? I can modify pavement.py, so that paver tries to build it, but doesn't fail with a build error, when that didn't work.

The latest commit in this branch now only warns, when there is no tar.xz, but continues to create the rest of the usual paver sdist stuff.

@coveralls

Coverage Status

Coverage remained the same when pulling 351ac0d on tomspur:tar.xz into 5309706 on scipy:master.

@pv pv added the PR label Feb 19, 2014
@rgommers rgommers added a commit that referenced this pull request Feb 23, 2014
@rgommers rgommers Merge branch 'pr/3278' into master.
Review at #3278
0da153e
@rgommers
SciPy member

Indeed, last commit fixes the issue. Squashed and merged in 0da153e. Thanks @tomspur

@rgommers rgommers closed this Feb 23, 2014
@rgommers rgommers added this to the 0.14.0 milestone Feb 23, 2014
@tomspur
tomspur commented Feb 24, 2014

Thanks @rgommers

@tomspur tomspur deleted the tomspur:tar.xz branch Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.