ENH: signal: Allow upsweeps of frequency in the 'hyperbolic' chirp. #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restriction that f0 > f1 > 0 has been removed. The only requirement is that f0 and f1 are not zero. Negative frequencies can be given. (Even f0 and f1 with opposite signs are allowed, but this is not expected to be a useful case.) The degenerate case with f0 == f1 is now also handled. Two small changes not directly related to the above change: * Changed "geometric" to "logarithmic" in the argument of the ValueError that can be raised when method="logaithmic". * Added `t = asarray(t)` in the function _chirp_phase, so the 't' argument of `chirp` is now `array_like`. Closes scipygh-3285.
|
Changes Unknown when pulling 889f451 on WarrenWeckesser:signal-chirp-hyp into * on scipy:master*. |
rgommers
added a commit
that referenced
this pull request
Feb 23, 2014
ENH: signal: Allow upsweeps of frequency in the 'hyperbolic' chirp.
|
Looks OK to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restriction that f0 > f1 > 0 has been removed. The only requirement
is that f0 and f1 are not zero. Negative frequencies can be given.
(Even f0 and f1 with opposite signs are allowed, but this is not expected
to be a useful case.) The degenerate case with f0 == f1 is now also
handled.
Two small changes not directly related to the above change:
that can be raised when method="logarithmic".
t = asarray(t)in the function_chirp_phase, so the 't' argumentof
chirpis nowarray_like.Closes gh-3285.