ENH: signal: Allow upsweeps of frequency in the 'hyperbolic' chirp. #3293

Merged
merged 1 commit into from Feb 23, 2014

Conversation

Projects
None yet
5 participants
Member

WarrenWeckesser commented Feb 6, 2014

The restriction that f0 > f1 > 0 has been removed. The only requirement
is that f0 and f1 are not zero. Negative frequencies can be given.
(Even f0 and f1 with opposite signs are allowed, but this is not expected
to be a useful case.) The degenerate case with f0 == f1 is now also
handled.

Two small changes not directly related to the above change:

  • Changed "geometric" to "logarithmic" in the argument of the ValueError
    that can be raised when method="logarithmic".
  • Added t = asarray(t) in the function _chirp_phase, so the 't' argument
    of chirp is now array_like.

Closes gh-3285.

ENH: signal: Allow upsweeps of frequency in the 'hyperbolic' chirp.
The restriction that f0 > f1 > 0 has been removed.  The only requirement
is that f0 and f1 are not zero.  Negative frequencies can be given.
(Even f0 and f1 with opposite signs are allowed, but this is not expected
to be a useful case.)  The degenerate case with f0 == f1 is now also
handled.

Two small changes not directly related to the above change:
* Changed "geometric" to "logarithmic" in the argument of the ValueError
  that can be raised when method="logaithmic".
* Added `t = asarray(t)` in the function _chirp_phase, so the 't' argument
  of `chirp` is now `array_like`.

Closes gh-3285.

@WarrenWeckesser WarrenWeckesser added this to the 0.14.0 milestone Feb 6, 2014

Coverage Status

Changes Unknown when pulling 889f451 on WarrenWeckesser:signal-chirp-hyp into * on scipy:master*.

@pv pv added the PR label Feb 19, 2014

rgommers added a commit that referenced this pull request Feb 23, 2014

Merge pull request #3293 from WarrenWeckesser/signal-chirp-hyp
ENH: signal: Allow upsweeps of frequency in the 'hyperbolic' chirp.

@rgommers rgommers merged commit 23df548 into scipy:master Feb 23, 2014

1 check passed

default The Travis CI build passed
Details
Owner

rgommers commented Feb 23, 2014

Looks OK to me, merging.

@WarrenWeckesser WarrenWeckesser deleted the WarrenWeckesser:signal-chirp-hyp branch Mar 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment