BUG: sparse/dsolve: detect invalid LAPACK parameters in superlu and bail out gracefully #3373

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
3 participants
@pv
Member

pv commented Feb 22, 2014

Hack around gh-3312.

LAPACK *TRSV require lda >= n. Catch this earlier, and bail out more gracefully with runtimerror before calling LAPACK with invalid arguments (which usually crashes the program).

The !VENDOR_BLAS code path does something also in the failing case. It's unclear if this is intended behavior, however.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Feb 22, 2014

Coverage Status

Coverage remained the same when pulling 82d4a75 on pv:superlu-fix-lapack into 1b34692 on scipy:master.

Coverage Status

Coverage remained the same when pulling 82d4a75 on pv:superlu-fix-lapack into 1b34692 on scipy:master.

rgommers added a commit that referenced this pull request Feb 25, 2014

Merge pull request #3373 from pv/superlu-fix-lapack
BUG: sparse/dsolve: detect invalid LAPACK parameters in superlu and bail out gracefully

@rgommers rgommers merged commit c4f3908 into scipy:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
@rgommers

This comment has been minimized.

Show comment Hide comment
@rgommers

rgommers Feb 25, 2014

Member

Thanks, merged.

Member

rgommers commented Feb 25, 2014

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment