MAINT integrate/odepack: kill dead Fortran code #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 7130bb2 on larsmans:cleanup-odepack into * on scipy:master*. |
|
+1 for removing if it gives warnings. |
pv
added a commit
that referenced
this pull request
May 17, 2014
MAINT: integrate/odepack: remove unused Fortran code
|
Removing unused files is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking out compiler warnings again and this time I found out we ship and build at least 6 kLOC of dead Fortran code in
scipy/integrate/odepack(a lot of it comments, but not the kind that I can understand). I took the liberty of removing some of it.It seems the code wasn't pristine anyway: it carries on
indexfile that doesn't match what is there.