Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY avoid unnecessary transposes in csr_matrix.getcol/row #3772

Merged
merged 1 commit into from
Aug 17, 2014

Conversation

jnothman
Copy link
Contributor

@jnothman jnothman commented Jul 5, 2014

No description provided.

@rgommers rgommers added this to the 0.15.0 milestone Jul 5, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 84f3ecc on jnothman:simplify-csc-getcol into 1007cec on scipy:master.

@perimosocordiae
Copy link
Member

Looks like the comments need to be updated, because they both mention transposing.

@jnothman
Copy link
Contributor Author

jnothman commented Jul 7, 2014

Fair enough.

On 7 July 2014 09:00, CJ Carey notifications@github.com wrote:

Looks like the comments need to be updated, because they both mention
transposing.


Reply to this email directly or view it on GitHub
#3772 (comment).

@jnothman
Copy link
Contributor Author

jnothman commented Jul 7, 2014

amended.

On 7 July 2014 09:22, Joel Nothman jnothman@student.usyd.edu.au wrote:

Fair enough.

On 7 July 2014 09:00, CJ Carey notifications@github.com wrote:

Looks like the comments need to be updated, because they both mention
transposing.


Reply to this email directly or view it on GitHub
#3772 (comment).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling f65eddd on jnothman:simplify-csc-getcol into defbe95 on scipy:master.

@pv pv removed the PR label Aug 13, 2014
rgommers added a commit that referenced this pull request Aug 17, 2014
STY avoid unnecessary transposes in csr_matrix.getcol/row
@rgommers rgommers merged commit 1ec5c8b into scipy:master Aug 17, 2014
@rgommers
Copy link
Member

Merged, thanks @jnothman, @perimosocordiae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants