DOC: sparse: clarify CSC and CSR constructor usage #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsmans
force-pushed
the
csc-csr-constructor-docstring
branch
from
c93d2d6
to
57eda02
Compare
|
Would it make sense to use the actual attribute names ( |
|
Those are not attributes on CSR and CSC. The constructor just takes COO-style inputs and converts them. (But maybe |
Same treatment as given to COO in 3f19f49. [ci skip]
larsmans
force-pushed
the
csc-csr-constructor-docstring
branch
from
57eda02
to
7c127cb
Compare
|
Changed the names to |
|
Looks good to me! |
WarrenWeckesser
added
Documentation
WarrenWeckesser
added a commit
that referenced
this pull request
Nov 22, 2014
DOC: sparse: clarify CSC and CSR constructor usage
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same treatment as given to COO in 3f19f49.