BLD: setup.py: update min numpy version and support "setup.py develop" #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
Build issues
| @@ -230,7 +230,8 @@ def setup_package(): | |||
| FULLVERSION, GIT_REVISION = get_version_info() | |||
| metadata['version'] = FULLVERSION | |||
| else: | |||
| if len(sys.argv) >= 2 and sys.argv[1] == 'bdist_wheel': | |||
| if (len(sys.argv) >= 2 and sys.argv[1] == 'bdist_wheel') or ( | |||
| 'develop' in sys.argv): | |||
There was a problem hiding this comment.
Shouldn't this change to develop go up in line 219?
sys.argv[1] in ('--help-commands', 'egg_info', '--version', 'clean', 'develop')
I think we want to avoid entering the else condition on line 232 completely, since this is the block that imports numpy.
There was a problem hiding this comment.
No: running setup.py develop requires numpy.
There was a problem hiding this comment.
The if clause above is only for a collection of commands that use setuptools but do not build scipy.
|
straightforward fix - going to merge this soon-ish |
rgommers
added a commit
that referenced
this pull request
Feb 20, 2015
BLD: setup.py: update min numpy version and support "setup.py develop"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.