References added for watershed_ift algorithm #4496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1346,7 +1346,7 @@ def _hist(vals): | |||
|
|
|||
| def watershed_ift(input, markers, structure=None, output=None): | |||
| """ | |||
| Apply watershed from markers using an iterative forest transform algorithm. | |||
| Apply watershed from markers using image foresting transform algorithm [1]. | |||
There was a problem hiding this comment.
I think this should be [1]_ instead of [1].
There was a problem hiding this comment.
Thanks. I did a new commit to add the underscore.
rgommers
added
Documentation
|
Adding this reference looks useful. There are a few minor style issues with this PR (first line too long, formatting of reference) that I fixed here: rgommers@04ee4028af3 I also squashed the commits and edited the commit message to be a more standard format. If that looks OK to you I'll merge that one. |
|
@rgommers That looks great! I'm sorry I missed the standard. It looks great now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the original reference to the watershed transform implemented using the Image Foresting Transform algorithm.