TST: increase scipy.optimize test coverage for disp=True

[argriffing]

This includes a new decorator in _lib._testutils for silencing output of specific tests, inspired by https://github.com/numpy/numpy/blob/master/numpy/testing/decorators.py and https://github.com/numpy/numpy/blob/maintenance/1.9.x/numpy/lib/tests/test_regression.py#L171, and it reorganizes the optimization tests by adding an object oriented hierarchy inspired by the scipy.sparse test framework, replacing

    def test_minimize(self):
        # Tests for the minimize wrapper.
        self.setUp()
        self.test_bfgs(True)
        self.setUp()
        self.test_bfgs_infinite(True)
        self.setUp()
        self.test_cg(True)
        self.setUp()
        self.test_ncg(True)
        self.setUp()
        self.test_ncg_hess(True)
        self.setUp()
        self.test_ncg_hessp(True)
        self.setUp()
        self.test_neldermead(True)
        self.setUp()
        self.test_powell(True)
        self.setUp()
        self.test_custom()

closes #4804

[pv]

os.devnull on windows?

[ewmoore]

os.devnull should be fine on windows.

On Mon, May 4, 2015 at 12:49 PM, Pauli Virtanen notifications@github.com
wrote:

os.devnull on windows?

—
Reply to this email directly or view it on GitHub
#4805 (comment).

[argriffing]

os.devnull on windows?

numpy uses it...

Edit: it exists on windows according to https://docs.python.org/2/library/os.html#os.devnull

[dlax]

What's the point of this surrounding function if the decorator does not accept arguments? Unless I'm missing something, it could just be the underlying function suppressed_stdout_decorator, which would be used simply as @suppressed_stdout (no parentheses).

[argriffing]

@dlax Thanks for your comment, I've simplified the decorator. I was afraid that if I didn't make it look like an airport then planes wouldn't land with cargo.

[rgommers]

This is tricky to get right. I think stdout.close() doesn't do what you'd expect, see numpy/numpy@3fd6b62c1db915

Also see this context manager for redirecting stdout which may somehow be useful/informative: numpy/numpy#3128

[rgommers]

+1 for this idea though. We may want to add this decorator to numpy.testing once it's been proven to be robust (i.e. no complaints for a month or so after this has been merged).

[argriffing]

I don't know how to progress further with this PR, but I've opened a numpy issue numpy/numpy#5891.

[rgommers]

It's late and I haven't thought about this very hard, but I think your code is actually OK. sys.stdout.close() doesn't work for the original sys.stdout, but you're only doing this on your dummy stdout so should work.

[rgommers]

If my comment above makes sense, and this PR works without generating any noise, maybe just merge it. Any issues have about 5 months until the next release to surface.

[argriffing]

OK I've merged it!