Patch to compute the volume and area of convex hulls #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. As a general rule, I would use `assert_allclose(a, b,
rtol=1e-14)` for comparing floating point numbers, instead of
`assert_equal(a, b)`.
|
pv
added a commit
that referenced
this pull request
Jul 3, 2015
ENH: spatial: make convex hull area and volume available
|
Ok, merged in a254ee1 with minor additions.
|
|
Ok thank you ! I also just added another test from random input on my branch (This was to compare it with my old and bad bindings of libqhullcpp), feel free to add it if you think it is useful. |
|
That could be useful --- you can send it in a second pull request.
|
|
Thanks for this patch, I was sorely missing this method! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #5013 , I would like to be able to contribute a small patch enabling the volume and area computation of convex hulls.
As this is already implemented in qhull, I added the correct bindings and a simple unit test. Unfortunately, I don't have Cython 0.22 on my Ubuntu machine, meaning that I could not build against the most recent version of scipy but test passed on older versions and I don't think qhull has changed much since.
Please tell me if I can improve this in any way.
Hervé Audren