MAINT: special: Cephes cleanup #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using the decimal float constants since 71e2f1b, and they've worked fine. The only feature we lose is the ability to run on the VAX.
I.e., the ones also offered by C89 or NumPy.
These routines were not reentrant, and NumPy has similar functionality anyway.
rgommers
added
scipy.special
maintenance
|
LGTM. In it goes. Thanks @larsmans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed thousands of lines of code in Cephes: mostly tables of float constants that it provides in four variants, of which we only ever use one. Cephes is still a lot of code, but it's coming close to being actually readable.