Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: special: Cephes cleanup #5111

Merged
merged 4 commits into from Aug 7, 2015

Conversation

Projects
None yet
3 participants
@larsmans
Copy link
Contributor

commented Aug 4, 2015

Removed thousands of lines of code in Cephes: mostly tables of float constants that it provides in four variants, of which we only ever use one. Cephes is still a lot of code, but it's coming close to being actually readable.

larsmans added some commits Aug 3, 2015

MAINT: special: remove tables of hex and octal constants
We've been using the decimal float constants since
71e2f1b, and they've worked fine.
The only feature we lose is the ability to run on the VAX.

@larsmans larsmans force-pushed the larsmans:cleanup branch from 962ea10 to 493bbb5 Aug 4, 2015

larsmans added some commits Aug 4, 2015

MAINT: special: remove unnecessary Cephes constants
I.e., the ones also offered by C89 or NumPy.
MAINT: special: remove Cephes polynomial routines
These routines were not reentrant, and NumPy has similar functionality
anyway.

@larsmans larsmans force-pushed the larsmans:cleanup branch from 493bbb5 to 8e76f30 Aug 4, 2015

@ewmoore

This comment has been minimized.

Copy link
Member

commented Aug 7, 2015

LGTM. In it goes. Thanks @larsmans.

ewmoore added a commit that referenced this pull request Aug 7, 2015

Merge pull request #5111 from larsmans/cleanup
MAINT: special: Cephes cleanup

@ewmoore ewmoore merged commit 07c2638 into scipy:master Aug 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ewmoore ewmoore added this to the 0.17.0 milestone Aug 7, 2015

@larsmans larsmans deleted the larsmans:cleanup branch Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.