MAINT: changed stats.pointbiserialr to delegate to stats.pearsonr
#5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed to delegate to @rgommers ping. |
rgommers
added
scipy.stats
maintenance
| ----- | ||
| For testing the hypothesis that the point-biserial correlation coefficient | ||
| is significantly different from zero, a t-test with n-2 degrees of freedom | ||
| should be used. Pearsonr is equivalent. |
There was a problem hiding this comment.
This looks like a suggestion to users to use a ttest_* function, while it tries to explain the algorithm, So I'd rephrase this as:
`pointbiserialr` uses a t-test with ``n-2`` degrees of freedom.
It is equivalent to `pearsonr`.
|
A few minor things in the Notes section, otherwise LGTM. |
Documentation notes were added (i.e. formulae and references) closes scipygh-627
aeklant
force-pushed
the
pointbiserialr
branch
from
26b2576
to
c89bee9
Compare
|
Comments addressed. |
rgommers
added a commit
that referenced
this pull request
Aug 17, 2015
MAINT: changed `stats.pointbiserialr` to delegate to `stats.pearsonr`
|
LGTM now, merged. Thanks @aeklant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation notes were added (i.e. formulae and references)
closes gh-627