Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify replacement of fftpack by pyfftw #5295

Merged
merged 2 commits into from Oct 10, 2015

Commits on Sep 27, 2015

  1. Simplify replacement of fftpack by pyfftw

    This patch replaces all instances of `from scipy.fftpack import ...`
    by `from scipy import fftpack` followed by the use of qualified
    names (except in the `scipy.fftpack` submodule itself).  The idea is
    to simplify the replacement of `scipy.fftpack` by the FFTW-backed
    `pyfftw.interfaces.scipy_fftpack`, which provides the same interface.
    
    Currently, acceleration of e.g. `scipy.signal.fftconvolve`
    requires fixing individual functions in `scipy.signal.signaltools`
    (`scipy.signal.signaltools.fftn = pyfftw.interfaces.scipy_fftpack.fftn;
    scipy.signal.signaltools.ifftn = pyfftw.interfaces.scipy_fftpack.ifftn`)
    because `signaltools` imports the functions out of `fftpack`.
    With the patch, a simple `scipy.fftpack.__dict__.update({name:
    getattr(pyfftw.interfaces.scipy_fftpack, name) for name in
    pyfftw.interfaces.scipy_fftpack.__all__})` (which could be wrapped in a
    helper in pyfftw's side) should suffice.
    anntzer committed Sep 27, 2015
    Configuration menu
    Copy the full SHA
    f0e77c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2015

  1. Add tests.

    anntzer committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    a370031 View commit details
    Browse the repository at this point in the history