BUG: sparse: fix a bug in sparsetools input dtype resolution #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the determined common input dtype for the c++ code is such that all inputs can be safely cast into it. Also require that the common dtype can be safely cast to output arguments. Add tests. Remove some upcasts that this makes unnecessary.
rgommers
added
scipy.sparse
maintenance
perimosocordiae
added a commit
that referenced
this pull request
Nov 21, 2015
BUG: sparse: fix a bug in sparsetools input dtype resolution
|
This looks good and Travis is happy. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the determined common input dtype for the c++ code is such that
all inputs can be safely cast into it. Also require that the common
dtype can be safely cast to output arguments.
Add tests. Remove some upcasts that this makes unnecessary.
Fixing up the issue mentioned in my comment at gh-5213
Typically, this bug was not triggered, since the sparse code Python side tends to be careful with the dtypes.