MAINT: remove uses of np.testing.rand #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually a vily alias for stdlib random. Use np.random instead.
@@ master #5663 diff @@
======================================
Files 234 234
Stmts 43267 43267
Branches 8178 8178
Methods 0 0
======================================
Hit 33520 33520
Partial 2618 2618
Missed 7129 7129
|
rgommers
added a commit
that referenced
this pull request
Jan 4, 2016
MAINT: remove uses of np.testing.rand
|
Thanks Evgeni, merged. |
|
And agreed that this doesn't need a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a follow-up to #5661.
Having
np.testing.randlikely made sense in 2002 (was it scipy_core.testing.rand then?), but not so much now that we rely onnumpy.randomalmost everywhere.These have not been reported as causing immediate trouble, so these probably can be just treated as a regular maintenance, unlike gh-5661 which is a backport material.