Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds plotting options to voronoi_plot_2d #5831

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

pwolfram
Copy link
Contributor

Simple (minor) additions to plotting routine for additional functionality that is useful for plotting unstructured grids.

@pwolfram pwolfram force-pushed the improve_options_to_voronoi_plot_2d branch from 165e308 to a82e444 Compare February 11, 2016 01:17
@pv pv added the needs-work Items that are pending response from the author label Feb 15, 2016
@pv
Copy link
Member

pv commented Feb 15, 2016

if kw.get('show_vertices', True):
ax.plot(vor.vertices[:,0], vor.vertices[:,1], 'o')

line_colors = kw.get('line_colors', 'k')
line_width = kw.get('line_width', '1')
line_alpha = kw.get('line_alpha', '1.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default values for width and alpha probably should be floats, not strings.

@pwolfram pwolfram force-pushed the improve_options_to_voronoi_plot_2d branch from 8faddcd to 35559fe Compare February 19, 2016 21:52
@codecov-io
Copy link

@@            master   #5831   diff @@
======================================
  Files          237     237       
  Stmts        43515   43523     +8
  Branches      8161    8162     +1
  Methods          0       0       
======================================
- Hit          33945   33943     -2
- Partial       2600    2601     +1
- Missed        6970    6979     +9

Review entire Coverage Diff as of c85d9bb

Powered by Codecov. Updated on successful CI builds.

@pv pv removed the needs-work Items that are pending response from the author label Feb 19, 2016
@pv pv added this to the 0.18.0 milestone Feb 19, 2016
pv added a commit that referenced this pull request Feb 19, 2016
…t_2d

ENH: spatial: adds plotting options to voronoi_plot_2d
@pv pv merged commit 94ee2c4 into scipy:master Feb 19, 2016
@pv
Copy link
Member

pv commented Feb 19, 2016

thanks, merged

@pv pv added enhancement A new feature or improvement scipy.spatial labels Feb 19, 2016
@pwolfram
Copy link
Contributor Author

Thanks @pv!

@pwolfram pwolfram deleted the improve_options_to_voronoi_plot_2d branch February 20, 2016 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.spatial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants