Fix bugs in sparsetools #5847
Merged
Fix bugs in sparsetools #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup should iterate through the argument list in the same way as the other loops; avoids accessing spec out-of-bounds and other incorrect behavior. Fixes scipygh-4510
@@ master #5847 diff @@
======================================
Files 235 235
Stmts 43388 43388
Branches 8167 8167
Methods 0 0
======================================
- Hit 33784 33782 -2
- Partial 2592 2593 +1
- Missed 7012 7013 +1
|
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix low-hanging bugs in sparsetools.cxx
Fixes gh-4476, gh-4510