BUG: sparse.linalg: add locks to ensure ARPACK threadsafety #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ARPACK fortran code uses SAVE variables, and is not threadsafe or re-entrant. Add locks and reentrancy checks to the Python side to deal with this issue --- previously the code used to segfault. As we use an explicit lock, it is not necessary for the Fortran code to hold the GIL, so adjust the .pyf file accordingly. Fixes scipygh-5846
@@ master #5848 diff @@
======================================
Files 236 237 +1
Stmts 43344 43374 +30
Branches 8134 8135 +1
Methods 0 0
======================================
+ Hit 33803 33832 +29
- Partial 2585 2586 +1
Missed 6956 6956
|
|
LGTM as is. However, this will mean that we have two slightly different versions of reentrancy check code in |
|
refactored |
| @@ -42,6 +42,8 @@ | |||
|
|
|||
| __all__ = ['eigs', 'eigsh', 'svds', 'ArpackError', 'ArpackNoConvergence'] | |||
|
|
|||
| import contextlib | |||
| import threading | |||
There was a problem hiding this comment.
These imports aren't necessary anymore I don't think.
pv
force-pushed
the
arpack-threadsafety
branch
from
3978f43
to
b272920
Compare
|
removed unnecessary imports |
ev-br
added a commit
that referenced
this pull request
Feb 17, 2016
BUG: sparse.linalg: add locks to ensure ARPACK threadsafety
|
Thanks, merged. |
ev-br
added
defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ARPACK fortran code uses SAVE variables, and is not threadsafe or
re-entrant. Add locks and reentrancy checks to the Python side to deal
with this issue --- previously the code used to segfault.
As we use an explicit lock, it is not necessary for the Fortran code to
hold the GIL, so adjust the .pyf file accordingly.
Fixes gh-5846